Repository navigation
fix: app launch with app.css hot module update - #6879
Merged
Merged
Conversation
Fix the application launch when there is an app.css change in a hot module update.
ghost
assigned
vchimev
approved these changes
Feb 8, 2019
Author
|
test package_version#rc |
1 similar comment
Contributor
|
test package_version#rc |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The application launch is crashing with
JS ERROR TypeError: undefined is not an object (evaluating 'this._rootView._onLivesync')when there is an app.css change in a hot module update.What is the new behavior?
The application launches successfully when there is an app.css change in a hot module update.