release: cut the 5.2.0 release #6878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
MartoYankov
reviewed
Feb 8, 2019
CHANGELOG.md
Outdated
|
|
||
| * call onNavigatingFrom event only if it exists ([#6773](https://github.com/NativeScript/NativeScript/issues/6773)) ([19dfd16](https://github.com/NativeScript/NativeScript/commit/19dfd16)) | ||
| * **android:** raise resume event on activity.onPostResume() ([#6766](https://github.com/NativeScript/NativeScript/issues/6766)) ([46c9de0](https://github.com/NativeScript/NativeScript/commit/46c9de0)) | ||
| * iOS tests ([4c15f71](https://github.com/NativeScript/NativeScript/commit/4c15f71)) |
Contributor
There was a problem hiding this comment.
Suggested change
| * iOS tests ([4c15f71](https://github.com/NativeScript/NativeScript/commit/4c15f71)) |
MartoYankov
reviewed
Feb 8, 2019
CHANGELOG.md
Outdated
|
|
||
| * add rebeccapurple to known css colors ([#6819](https://github.com/NativeScript/NativeScript/issues/6819)) ([672c821](https://github.com/NativeScript/NativeScript/commit/672c821)) | ||
| * OnDiscardedError typings and event ([#6777](https://github.com/NativeScript/NativeScript/issues/6777)) ([28db2af](https://github.com/NativeScript/NativeScript/commit/28db2af)) | ||
| * **action-bar:** flat mode breaks ios safe area ([#6862](https://github.com/NativeScript/NativeScript/issues/6862)) ([603c901](https://github.com/NativeScript/NativeScript/commit/603c901)) |
Contributor
There was a problem hiding this comment.
This should be moved to fixes. My bad with the commit naming.
vchimev
reviewed
Feb 8, 2019
CHANGELOG.md
Outdated
| * **android:** raise resume event on activity.onPostResume() ([#6766](https://github.com/NativeScript/NativeScript/issues/6766)) ([46c9de0](https://github.com/NativeScript/NativeScript/commit/46c9de0)) | ||
| * **android:** animator restore logic on simulated nav ([#6710](https://github.com/NativeScript/NativeScript/issues/6710)) ([c034d6e](https://github.com/NativeScript/NativeScript/commit/c034d6e)) | ||
| * **android:** failure saving state in mixed parent/nested frame nav ([#6719](https://github.com/NativeScript/NativeScript/issues/6719)) ([4dc35a5](https://github.com/NativeScript/NativeScript/commit/4dc35a5)) | ||
| * **Android:** a crash on application restart after livesync changes ([#6756](https://github.com/NativeScript/NativeScript/issues/6756)) ([1f1d722](https://github.com/NativeScript/NativeScript/commit/1f1d722)) |
Contributor
There was a problem hiding this comment.
Suggested change
| * **Android:** a crash on application restart after livesync changes ([#6756](https://github.com/NativeScript/NativeScript/issues/6756)) ([1f1d722](https://github.com/NativeScript/NativeScript/commit/1f1d722)) | |
| * **android:** a crash on application restart after livesync changes ([#6756](https://github.com/NativeScript/NativeScript/issues/6756)) ([1f1d722](https://github.com/NativeScript/NativeScript/commit/1f1d722)) |
vchimev
reviewed
Feb 8, 2019
CHANGELOG.md
Outdated
| * **ios:** textview content clipped on every other newline ([#6864](https://github.com/NativeScript/NativeScript/issues/6864)) ([23dc84d](https://github.com/NativeScript/NativeScript/commit/23dc84d)) | ||
| * **ios-frame:** tearDownUI and reset UINavigationController ([#6817](https://github.com/NativeScript/NativeScript/issues/6817)) ([cea97c6](https://github.com/NativeScript/NativeScript/commit/cea97c6)) | ||
| * **list-view-android:** app crashes on ListView item template change ([#6634](https://github.com/NativeScript/NativeScript/issues/6634)) ([2085d1e](https://github.com/NativeScript/NativeScript/commit/2085d1e)) | ||
| * **modal:** Fix crash if modal is destroyed before dismissed in Android ([#6723](https://github.com/NativeScript/NativeScript/issues/6723)) ([8a32102](https://github.com/NativeScript/NativeScript/commit/8a32102)) |
Contributor
There was a problem hiding this comment.
Suggested change
| * **modal:** Fix crash if modal is destroyed before dismissed in Android ([#6723](https://github.com/NativeScript/NativeScript/issues/6723)) ([8a32102](https://github.com/NativeScript/NativeScript/commit/8a32102)) | |
| * **modal:** fix a crash if modal is destroyed before dismissed in Android ([#6723](https://github.com/NativeScript/NativeScript/issues/6723)) ([8a32102](https://github.com/NativeScript/NativeScript/commit/8a32102)) |
manoldonev
approved these changes
Feb 8, 2019
Contributor
Author
|
test package_version#rc |
SvetoslavTsenov
force-pushed
the
release-5.2.0
branch
from
d95d819 to
35fd793
Compare
vchimev
approved these changes
Feb 8, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.