Skip to content

Conversation

@SvetoslavTsenov
Copy link
Contributor

No description provided.

manoldonev and others added 30 commits October 26, 2018 13:32
Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.
* fix: don't crash on startup due to tslib not being found

* fix: prevent error 'sourceMap' cannot be specified with option 'inlineSourceMap'

* Revert "fix: prevent error 'sourceMap' cannot be specified with option 'inlineSourceMap'"

This reverts commit c9d96de.

* chore: updates tsconfig.json file
* docs: add 5.0.0 changelog

* docs: merge 5.0.0 RC and 5.0.0 changelogs
* fix: crash on Android Tab-View #6466

This fix has been tested in production with no new issues occurring.

Long-term solution would be one of the following, though:
1. reintroduce overrides for `saveState`/`restoreState` in the current PagerAdapter implementation (removed on this commit ac04ede#diff-f1459d509d1432b432c29bcd30e462fbL97)
2. use FragmentPagerAdapter
3. use FragmentStatePagerAdapter

Both 2 and 3 manage the save/restore cycles. The main difference between 2 and 3 is that 2 uses more memory, but allows for quicker switching between Fragments than 3. Since tabs should usually be limited to 5 or less, this may be the best choice to maintain performance, which is important for top level navigation tabs.

When I have more time I may experiment with these options myself to see what the difference to performance and memory consumption is for each.

* refactor: _commitCurrentTransaction method+comment

* chore: fix typo

* fix: missing class definition
@ns-bot
Copy link

ns-bot commented Nov 20, 2018

Please sign CLA at http://www.nativescript.org/cla

@ns-bot ns-bot added the cla: no label Nov 20, 2018
@SvetoslavTsenov SvetoslavTsenov merged commit 6daba69 into release Nov 20, 2018
@ghost ghost removed the in progress label Nov 20, 2018
@SvetoslavTsenov SvetoslavTsenov deleted the release-5.0.3 branch November 20, 2018 14:12
SvetoslavTsenov added a commit that referenced this pull request Nov 20, 2018
SvetoslavTsenov added a commit that referenced this pull request Nov 26, 2018
Merge pull request #6584 from NativeScript/release-5.0.3
@lock
Copy link

lock bot commented Nov 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.