Skip to content

fix(tab-view-android): change androidOffscreenTabLimit to 1 #6476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SvetoslavTsenov merged 2 commits into from
Oct 30, 2018
Merged

fix(tab-view-android): change androidOffscreenTabLimit to 1 #6476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab8f54
fix(tab-view-android): change androidOffscreenTabLimit to 1 when usin…
Oct 30, 2018
d6c8742
Merge branch 'master' into djenkov/bottom-tab-view
ADjenkov Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tns-core-modules/ui/tab-view/tab-view.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ export class TabView extends TabViewBase {
public _loadUnloadTabItems(newIndex: number) {
const items = this.items;
const lastIndex = this.items.length - 1;
const offsideItems = this.androidTabsPosition === "top" ? this.androidOffscreenTabLimit : 0;
const offsideItems = this.androidTabsPosition === "top" ? this.androidOffscreenTabLimit : 1;

let toUnload = [];
let toLoad = [];
Expand Down