Skip to content

fix-next: correct raising of layoutChanged event #6457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MartoYankov merged 3 commits into from
Oct 26, 2018
Merged

fix-next: correct raising of layoutChanged event #6457

MartoYankov merged 3 commits into from
Oct 26, 2018

Conversation

@tgpetrov
Copy link
Contributor

@tgpetrov tgpetrov commented Oct 25, 2018 •
edited
Loading

PR Checklist

What is the current behavior?

Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.

What is the new behavior?

The check if the frame is actually changed is performed before the safe area transformations are applied.

Fixes/Implements/Closes #[Issue Number].

@tgpetrov
fix-next: correct raising of layoutChanged event
117225f 
Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.
@tgpetrov tgpetrov requested a review from MartoYankov October 25, 2018 14:39
@ghost ghost assigned tgpetrov Oct 25, 2018
@ghost ghost added the in progress label Oct 25, 2018
@ns-bot
Copy link

ns-bot commented Oct 25, 2018

Please sign CLA at http://www.nativescript.org/cla

@ns-bot ns-bot added the cla: no label Oct 25, 2018
@ns-bot
Copy link

ns-bot commented Oct 26, 2018

CLA signature found, happy contributing!

@ns-bot ns-bot added cla: yes and removed cla: no labels Oct 26, 2018
@ghost ghost assigned SvetoslavTsenov Oct 26, 2018
@ghost ghost assigned MartoYankov Oct 26, 2018
@tgpetrov tgpetrov mentioned this pull request Oct 26, 2018
Merged
@MartoYankov MartoYankov merged commit f5cca13 into master Oct 26, 2018
@MartoYankov MartoYankov deleted the tgpetrov/set-frame-check branch October 26, 2018 14:03
@ghost ghost removed the in progress label Oct 26, 2018
dtopuzov pushed a commit that referenced this pull request Oct 29, 2018
@tgpetrov @dtopuzov
fix-next: correct raising of layoutChanged event (#6457)
7f45c01 
Currently the layoutChanged event can be raised even when there is no change due to safe area calculations.
@manoldonev manoldonev mentioned this pull request Nov 7, 2018
Merged
@lock
Copy link

lock bot commented Oct 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MartoYankov MartoYankov MartoYankov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SvetoslavTsenov SvetoslavTsenov

@MartoYankov MartoYankov

@tgpetrov tgpetrov

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tgpetrov @ns-bot @MartoYankov @SvetoslavTsenov