Skip to content

fix: Clear the "view" to avoid left over referenced once the View is detached and should be collected by GC #6353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VladimirAmiorkov wants to merge 1 commit into from
Closed

fix: Clear the "view" to avoid left over referenced once the View is detached and should be collected by GC #6353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tns-core-modules/ui/styling/style-scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,9 @@ export class CssState {

public onUnloaded(): void {
this.unsubscribeFromDynamicUpdates();
this.view = undefined;
this._matchInvalid = false;
Copy link
Contributor

@facetious facetious Oct 4, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable is poorly named. "Match invalid = false" implies that the match is valid, but you're about to set the match to undefined, which strikes me as ultimately invalid. It is usually best to name boolean variables as the "positive"; i.e. change the naming of the variable to _matchValid so that you're not doing gymnastics to understand double-negatives.

This comment was marked as abuse.

Sign in to view

this._match = undefined;
}

@profile
Expand Down