Skip to content

fix(android): nested frames on app suspend/resume #6339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manoldonev merged 3 commits into from
Oct 4, 2018
Merged

fix(android): nested frames on app suspend/resume #6339

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6267085
fix(android): nested frames on app suspend/resume
manoldonev Oct 2, 2018
3a0d4bb
Merge branch 'master' into mdonev/already-has-a-parent-fix
manoldonev Oct 3, 2018
31c0a0a
Merge branch 'master' into mdonev/already-has-a-parent-fix
manoldonev Oct 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tns-core-modules/ui/frame/frame.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,17 @@ class FragmentCallbacksImplementation implements AndroidFragmentCallbacks {
if (traceEnabled()) {
traceWrite(`${fragment}.onDestroyView()`, traceCategories.NativeLifecycle);
}

// fixes 'java.lang.IllegalStateException: The specified child already has a parent. You must call removeView() on the child's parent first'.
// on app resume in nested frame scenarios with support library version greater than 26.0.0
const view = fragment.getView();
if (view != null) {
const viewParent = view.getParent();
if (viewParent instanceof android.view.ViewGroup) {
viewParent.removeView(view);
}
}

superFunc.call(fragment);
}

Expand Down