fix(android): suppress reflection for default animations #6141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
vakrilov
approved these changes
Aug 1, 2018
manoldonev
force-pushed
the
mdonev/support-lib-suppress-reflection
branch
from
cd26e30 to
bf2ba9c
Compare
manoldonev
changed the title
Contributor
|
test branch_ns_ng_animation_examples branch_qsf |
Member
|
@manoldonev Just tried it out 😄 |
Contributor
|
test branch_ns_ng_animation_examples branch_qsf |
2 similar comments
Contributor
|
test branch_ns_ng_animation_examples branch_qsf |
Contributor
|
test branch_ns_ng_animation_examples branch_qsf |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Error: java.lang.CloneNotSupportedException: Class android.support.v4.app.FragmentManagerImpl$AnimationOrAnimator doesn't implement Cloneablein specific projects.I was able to reproduce the problem when added the firebase plugin to a working hello-world app (cli next, android runtime next, tns-core-modules next). The root of the problem is the fact that different versions of the support library expose different API for android.support.v4.app.FragmentManagerImpl.loadAnimations(...) -- one returns Animation, the other AnimationOrAnimatior (that is not cloneable). Might be related to
NativeScript/nativescript-cli#3773 as we are really unsure which support library version is used (and why).
Related to #5785
Related to #6129
BREAKING CHANGE
Before:
Default fragment enter animation was Android version specific
After:
Default fragment enter animation is now fade animation for all Android versions
You can customise the transition per navigation entry or globally via the navigation transitions API