Skip to content

Fixing onReceiveError for API level >= 23 #6056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtopuzov merged 2 commits into from
Jul 13, 2018
Merged

Fixing onReceiveError for API level >= 23 #6056

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6576a0c
Fixing onReceiveError for API level >= 23
vtrifonov Jul 11, 2018
f2193b2
using @ts-ignore as "super as any" is not a valid statement
vtrifonov Jul 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tns-core-modules/ui/web-view/web-view.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,11 @@ function initializeWebViewClient(): void {
let request: any = arguments[1];
let error: any = arguments[2];

super.onReceivedError(view, request, error, null);
// before API version 23 there's no onReceiveError with 3 parameters, so it shouldn't come here
// but we don't have the onReceivedError with 3 parameters there and that's why we are ignorint tye typescript error
// @ts-ignore TS2554
super.onReceivedError(view, request, error);

const owner = this.owner;
if (owner) {
if (traceEnabled()) {
Expand Down Expand Up @@ -173,4 +177,4 @@ export class WebView extends WebViewBase {
return nativeView.reload();
}
}
}
}