Repository navigation
Added parameterless constructors in android typings - #6044
Merged
Merged
Conversation
vakrilov
approved these changes
Jul 13, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #6031
Currently in android typings we are generating classes accepting an implementation object for android interfaces. However if you want to create a class that implements an android interface you cannot just extend the generated android class as you'll need to supply the implementation in the super call. Here's an example:
In order this to be a valid typescript using the android typings we need to have a parameterless constructor in the
java.lang.Runnableclass.So this PR adds such an empty constructor to each class generated from android interface.