Skip to content

Profile iOS keypoints in the UINavigationViewController #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PanayotCankov merged 1 commit into from
Dec 4, 2017
Merged

Profile iOS keypoints in the UINavigationViewController #5108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tns-core-modules/application/application.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export * from "./application-common";
import { Frame, View, NavigationEntry } from "../ui/frame";
import { ios } from "../ui/utils";
import * as utils from "../utils/utils";
import { profile } from "../profiling";

class Responder extends UIResponder {
//
Expand All @@ -35,6 +36,7 @@ class Window extends UIWindow {
return window;
}

@profile
public layoutSubviews(): void {
if (utils.ios.MajorVersion < 9) {
ios._layoutRootView(this.content, utils.ios.getter(UIScreen, UIScreen.mainScreen).bounds);
Expand Down Expand Up @@ -112,6 +114,7 @@ class IOSApplication implements IOSApplicationDefinition {
}
}

@profile
private didFinishLaunchingWithOptions(notification: NSNotification) {
this._window = <Window>Window.alloc().initWithFrame(utils.ios.getter(UIScreen, UIScreen.mainScreen).bounds);
this._window.backgroundColor = utils.ios.getter(UIColor, UIColor.whiteColor);
Expand Down Expand Up @@ -146,6 +149,7 @@ class IOSApplication implements IOSApplicationDefinition {
this._window.makeKeyAndVisible();
}

@profile
private didBecomeActive(notification: NSNotification) {
let ios = utils.ios.getter(UIApplication, UIApplication.sharedApplication);
let object = this;
Expand Down
3 changes: 3 additions & 0 deletions tns-core-modules/ui/frame/frame.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,7 @@ class UINavigationControllerImpl extends UINavigationController {
}
}

@profile
public viewDidLayoutSubviews(): void {
let owner = this._owner.get();
if (owner) {
Expand Down Expand Up @@ -551,6 +552,7 @@ class UINavigationControllerImpl extends UINavigationController {
});
}

@profile
public pushViewControllerAnimated(viewController: UIViewController, animated: boolean): void {
let navigationTransition = <NavigationTransition>viewController[TRANSITION];
if (traceEnabled()) {
Expand All @@ -568,6 +570,7 @@ class UINavigationControllerImpl extends UINavigationController {
});
}

@profile
public setViewControllersAnimated(viewControllers: NSArray<any>, animated: boolean): void {
let viewController = viewControllers.lastObject;
let navigationTransition = <NavigationTransition>viewController[TRANSITION];
Expand Down
5 changes: 5 additions & 0 deletions tns-core-modules/ui/page/page.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ class UIViewControllerImpl extends UIViewController {
return controller;
}

@profile
public viewDidLayoutSubviews() {
let owner = this._owner.get();
if (!owner) {
Expand Down Expand Up @@ -131,6 +132,7 @@ class UIViewControllerImpl extends UIViewController {
}
}

@profile
public viewWillAppear(animated: boolean): void {
super.viewWillAppear(animated);
this.shown = false;
Expand Down Expand Up @@ -189,6 +191,7 @@ class UIViewControllerImpl extends UIViewController {
page._enableLoadedEvents = false;
}

@profile
public viewDidAppear(animated: boolean): void {
super.viewDidAppear(animated);
this.shown = true;
Expand Down Expand Up @@ -242,6 +245,7 @@ class UIViewControllerImpl extends UIViewController {
}
};

@profile
public viewWillDisappear(animated: boolean): void {
super.viewWillDisappear(animated);

Expand Down Expand Up @@ -270,6 +274,7 @@ class UIViewControllerImpl extends UIViewController {
page._viewWillDisappear = true;
}

@profile
public viewDidDisappear(animated: boolean): void {
super.viewDidDisappear(animated);

Expand Down