Fix clear history transition #4951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
vakrilov
suggested changes
Oct 16, 2017
| @@ -1,4 +1,4 @@ | |||
| { | |||
| "name": "tns-samples-apps", | |||
| "main": "ui-tests-app/app.js" | |||
| class NoTransition extends Transition { | ||
| public createAndroidAnimator(transitionType: string): android.animation.Animator { | ||
| return createDummyZeroDurationAnimator(); | ||
| export function _updateAnimations(entry: ExpandedEntry): void { |
Contributor
There was a problem hiding this comment.
rename to _updateTransitions
| return fragment[CALLBACKS] as FragmentCallbacks; | ||
| } | ||
|
|
||
| function updateCurrentFragmentTransitions(entry: ExpandedEntry): void { |
Contributor
There was a problem hiding this comment.
This looks the same as _updateAnimations
| animator.entry = null; | ||
| } | ||
|
|
||
| function clearTransitions(fragment: android.app.Fragment, removeListener: boolean): void { |
Contributor
There was a problem hiding this comment.
rename to clearReenterAndExitTransitions
|
|
||
| @profile | ||
| public onDestroy(fragment: android.app.Fragment, superFunc: Function): void { | ||
| const entry = this.entry; |
Contributor
There was a problem hiding this comment.
entry and page are unsused
| const entry = getFragmentCallbacks(fragment).entry; | ||
| switch (nextAnim) { | ||
| case enterFakeResourceId: | ||
| case AnimationType.enterFakeResourceId: |
Contributor
There was a problem hiding this comment.
Reminder: Move to frame.android
PanayotCankov
approved these changes
Oct 16, 2017
hshristov
force-pushed
the
fix-clear-history-transition
branch
from
029b197 to
3ea8596
Compare
vakrilov
approved these changes
Oct 17, 2017
Implemented custom fragment save/restore state. When navigating back we reverse manually transitions/animations because we no longer add them to navite backstack. Fragment instance stored on entry. Animation and Transition listeners now holds reference to entry instead of fragment for easier update of fragment. Animation and Transition listeners removed when entry removed from backstack. Animation and Transition removed from fragment when fragment activity is destroyed.
Fixed bug where goBack took the last element in backstack while navigationQueue is not empty. Fixed bug where goBack to specific entry in the backstack was removing that entry... Removed duplicated method Refactored method name Fixed TS
hshristov
force-pushed
the
fix-clear-history-transition
branch
from
3ea8596 to
331ad27
Compare
Contributor
|
run uitests ios |
Contributor
|
ios-issues |
Contributor
|
ios-pickers |
Contributor
|
ios-textbase |
Contributor
|
@hshristov, good news. It seems this PR is good to be merged. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4950
Implemented custom fragment save/restore state.
When navigating back we reverse manually transitions/animations because we no longer add them to navite backstack.
Fragment instance stored on entry.
Animation and Transition listeners now holds reference to entry instead of fragment for easier update of fragment.
Animation and Transition listeners removed when entry removed from backstack.
Animation and Transition removed from fragment when fragment activity is destroyed.