Ability to load local files in a WebView on iOS devices #4444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vakrilov
suggested changes
Jun 27, 2017
Contributor
vakrilov
left a comment
vakrilov
left a comment
There was a problem hiding this comment.
LGTM! Can you please remove the maked comments. They are used to generate code snippets for the docs. However there is already a snippet called webview-localfile in this file - no need for another.
| public testLoadLocalFileWithSpaceInPath(done) { | ||
| let webView = this.testView; | ||
|
|
||
| // >> webview-localfile |
|
|
||
| // >> webview-localfile | ||
| webView.on(webViewModule.WebView.loadFinishedEvent, function (args: webViewModule.LoadEventData) { | ||
| // >> (hide) |
| catch (e) { | ||
| done(e); | ||
| } | ||
| // << (hide) |
| } | ||
| }); | ||
| webView.src = "~/ui/web-view/test with spaces.html"; | ||
| // << webview-localfile |
Contributor
|
10x @EddyVerbruggen! |
…comments in test)
Contributor
Author
|
Thanks! The comments are gone now, good to learn what those are used for 👍 |
vakrilov
approved these changes
Jun 27, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4443, unittest added.