Skip to content

Fixing broken snippets in documentation - #3966

Merged
vakrilov merged 2 commits into
masterfrom
niliev/snippet-fix
Apr 12, 2017
Merged

vakrilov merged 2 commits into
masterfrom
niliev/snippet-fix

Conversation

@NickIliev

Copy link
Copy Markdown
Contributor

// function pageLoaded(args) {
// var page = args.object;
// var obj = new observable.Observable();
// export function pageLoaded(args) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this code is commented. It does not build this way, so there is no validation if the snippet is broken.

### Binding two TextViews text property to observable view-model property.
{%snippet text-view-xml%}
```XML
<Page loaded="pageLoaded">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid having snippets directly in mark-down. They are not subject to any validation this way

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've agreed that this should stay inline for now

@vakrilov
vakrilov merged commit 20bf5b7 into master Apr 12, 2017
@vakrilov
vakrilov deleted the niliev/snippet-fix branch April 12, 2017 10:19
@lock

lock Bot commented Aug 27, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Aug 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants