Repository navigation
Improve error message of fetch when xhr.onerror occurs - #3003
Merged
Merged
Conversation
|
Can one of the admins verify this patch? |
adamvoss
changed the title
fetch when xhr.onerror is occursfetch when xhr.onerror occurs
Contributor
|
run ci |
enchev
approved these changes
Nov 7, 2016
enchev
pushed a commit
that referenced
this pull request
Nov 7, 2016
* Ensure fetch-tests fail (instead of timeout) on failure * Standardize failure handling in fetch-tests * Improve flawed failure condition of test_fetch_json Previously, the assertion was always true * Implement better error message for for xhr.onerror within fetch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit message references a specific issue in this repo
Fixes/Implements #2952.
You have unit tests
Added one test to cover this case. Since I do not know what the error message will be on iOS, a pattern was used rather than checking for an exact message.
Additionally some cleanup of the existing tests was done to improve correctness of the tests. Some would timeout, rather than fail, swallowing the failure message.