Can one of the admins verify this patch?

@tjvantoll @jlooper Do either you have any additional context on why this UIImageRenderingMode was changed in the past? If there is no good reason to keep the change, the Automatic mode seems way more helpful as the default.

Please sign CLA at http://www.nativescript.org/cla

CLA signature found, happy contributing!

@toddanglin Unless I’m missing something, I don’t think UIImageRenderingMode actually changed in 1.5. Here’s the commit in question that landed in 1.5.1; here’s the PR. It looks like the change was using imageWithRenderingMode() instead of setting the renderingMode property directly.

I see UIImageRenderingModeAlwaysOriginal being used all the way back to the original commit that introduced the ability to add images to tabs back in March of 2015.

Not sure whether changing UIImageRenderingMode would have any repercussions, but I personally can’t think of any, and I like the idea of making selectedColor easier to use 😄

@tjvantoll Thanks for finding the old commit!

I recall in earlier versions of {N} the tab icon colors did change on iOS, so I wonder if something changed in iOS? Either way, this pull request would simply change the rendering mode to UIImageRenderingModeAutomatic, which seems to be a superior option for styling tab icons.

Apps that have already added multiple icons to deal with AlwaysOriginal rendering should only have to ensure selectedColor is properly set in their TabView to avoid any visual change.

If this change is too heavy handed, the next best thing (I suppose) would be a new property on the TabView allowing developers to specify "rendering mode"...but long-term I can't see why anyone would want to import more images just to deal with selected state coloring.

@toddanglin I merged the pull request. Thank you for this fix.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.