Skip to content

fix(webpack): find ExternalModuleFactoryPlugin where webpack 5.112 moved it - #11633

Merged
NathanWalker merged 1 commit into
mainfrom
fix/webpack-builtin-modules-5.112
Nov 10, 2026
Merged

NathanWalker merged 1 commit into
mainfrom
fix/webpack-builtin-modules-5.112

Conversation

@edusperoni

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

NativeScriptBuiltinModulesPlugin (#11626) loads webpack/lib/ExternalModuleFactoryPlugin. webpack 5.112 moved that file to webpack/lib/externals/, so on current webpack the config fails to load with Cannot find module 'webpack/lib/ExternalModuleFactoryPlugin'. This is the same kind of move #11547 fixed for WorkerDependency.

What is the new behavior?

The plugin loads webpack/lib/externals/ExternalModuleFactoryPlugin and falls back to the old path, matching the worker loader's approach. The class's constructor and apply(normalModuleFactory) are unchanged between 5.99 and 5.112.

Tested __tests__/plugins/NativeScriptBuiltinModulesPlugin.spec.ts (real ESM and CommonJS compiles) against:

  • webpack 5.99.9 (the repo's version): passes.
  • webpack 5.112.2, mapped in through a temporary jest config: passes with this change. Without it the suite fails to load.

CI only runs the repo's webpack version, so the 5.112 run was manual. The rest of the webpack suite is unchanged; its 14 failing snapshot tests also fail on main.

…ved it

webpack 5.112 moved lib/ExternalModuleFactoryPlugin.js to lib/externals/, so loading NativeScriptBuiltinModulesPlugin threw "Cannot find module". Try the new location first and fall back to the old one, as the worker loader does for WorkerDependency.
@nx-cloud

nx-cloud Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c1eceb0

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 38s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-11-10 15:24:36 UTC

@pkg-pr-new

pkg-pr-new Bot commented Nov 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11633
npm i https://pkg.pr.new/@nativescript/vite@11633
npm i https://pkg.pr.new/@nativescript/webpack@11633

commit: c1eceb0

@CatchABus

Copy link
Copy Markdown
Contributor

@edusperoni I have confirmed this change fixes the problem in one of my apps.

@NathanWalker
NathanWalker merged commit 5d099c8 into main Nov 10, 2026
10 checks passed
@NathanWalker
NathanWalker deleted the fix/webpack-builtin-modules-5.112 branch November 10, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants