Skip to content

fix(android): gesture single tap incorrect event data #11632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CatchABus wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(android): gesture single tap incorrect event data #11632

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08c38a9
fix(android): gesture single tap incorrect event data
CatchABus Nov 10, 2026
1f889a5
ref: avoid unnecessary clear timeout calls
CatchABus Nov 10, 2026
5df8a17
perf: avoid unneeded clear timeout call
CatchABus Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions packages/core/ui/gestures/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ import { GesturesObserverBase, toString, TouchAction, GestureStateTypes, Gesture
// Import layout from utils directly to avoid circular references
import { layout } from '../../utils/layout-helper';

import * as timer from '../../timer';

export * from './gestures-common';
export * from './gestures-types';
export * from './touch-manager';
Expand Down Expand Up @@ -40,7 +38,7 @@ function initializeTapAndDoubleTapGestureListener() {
private _type: GestureTypes;

private _lastUpTime = 0;
private _tapTimeoutId: number;
private _tapTimeoutId: NodeJS.Timeout;

private static DoubleTapTimeout = android.view.ViewConfiguration.getDoubleTapTimeout();

Expand Down Expand Up @@ -79,13 +77,25 @@ function initializeTapAndDoubleTapGestureListener() {

private _handleSingleTap(motionEvent: android.view.MotionEvent): void {
if (this._target.getGestureObservers(GestureTypes.doubleTap)) {
this._tapTimeoutId = timer.setTimeout(() => {
// In the case of having both tap and double-tap observers, keep a copy of motion event
// This will ensure that the event data will be the same even after tap timeout emits
const eventCp = android.view.MotionEvent.obtain(motionEvent);

const timeoutId = setTimeout(() => {
if (this._type === GestureTypes.tap) {
const args = _getTapArgs(GestureTypes.tap, this._target, motionEvent);
const args = _getTapArgs(GestureTypes.tap, this._target, eventCp);
_executeCallback(this._observer, args);
}
timer.clearTimeout(this._tapTimeoutId);

if (this._tapTimeoutId != null) {

@CatchABus CatchABus Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farfromrefug I made this small change after the review and thought of letting you know.

if (this._tapTimeoutId !== timeoutId) {
clearTimeout(this._tapTimeoutId);
} else {
this._tapTimeoutId = null;
}
}
}, TapAndDoubleTapGestureListenerImpl.DoubleTapTimeout);
this._tapTimeoutId = timeoutId;
} else {
if (this._type === GestureTypes.tap) {
const args = _getTapArgs(GestureTypes.tap, this._target, motionEvent);
Expand All @@ -95,8 +105,9 @@ function initializeTapAndDoubleTapGestureListener() {
}

private _handleDoubleTap(motionEvent: android.view.MotionEvent): void {
if (this._tapTimeoutId) {
timer.clearTimeout(this._tapTimeoutId);
if (this._tapTimeoutId != null) {
clearTimeout(this._tapTimeoutId);
this._tapTimeoutId = null;
}
if (this._type === GestureTypes.doubleTap) {
const args = _getTapArgs(GestureTypes.doubleTap, this._target, motionEvent);
Expand Down
Loading