Repository navigation
Conversation
|
View your CI Pipeline Execution ↗ for commit 5df8a17
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
farfromrefug
approved these changes
Nov 10, 2026
CatchABus
commented
Nov 10, 2026
| clearTimeout(this._tapTimeoutId); | ||
| } else { | ||
| this._tapTimeoutId = null; | ||
| if (this._tapTimeoutId != null) { |
Contributor
Author
There was a problem hiding this comment.
@farfromrefug I made this small change after the review and thought of letting you know.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When an android view has both single and double tap gesture observers, it emits the
tapevent delay to leave a small time window for a possible double tap.Unfortunately, the gesture emits the
MotionEventinstance with a delay resulting in incorrect data (e.g. android event system resets the motion to event screen coordinates when done).What is the new behavior?
These changes make sure that a copy of the motion event is kept before the timer.
The timer will emit the copy, hence the event data at the moment of the actual tap.
The PR also includes small changes regarding
setTimeout.