Skip to content

fix(devtools): show non-string ApplicationSettings values #11580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(devtools): show non-string ApplicationSettings values #11580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/devtools/src/impl/ApplicationSettingsKeyValueProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,18 @@ export class ApplicationSettingsKeyValueProvider implements KeyValueProvider {
return ApplicationSettings.getAllKeys();
}
getValue(key: string) {
return ApplicationSettings.getString(key);
// Android's typed getters throw ClassCastException when the stored value has a different type.
const readers = [() => ApplicationSettings.getString(key), () => ApplicationSettings.getBoolean(key), () => ApplicationSettings.getNumber(key)];
for (const read of readers) {
try {
const value = read();
return value === undefined ? undefined : String(value);
} catch {
// try the next type
}
}

return undefined;
}
setValue(key: string, value: string) {
ApplicationSettings.setString(key, value);
Expand Down
Loading