Repository navigation
fix(android): null keyboardType shows the default text keyboard - #11576
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit c5915ba
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On Android, setting
keyboardTypetonullon a TextField or TextView means the soft keyboard and caret never appear. The fallback branch converts the value with+value, and+nullis0, which isInputType.TYPE_NULL. On iOS the same0happens to beUIKeyboardType.Default, so this only breaks on Android. It comes up whenever a wrapper component setskeyboardTypedynamically and usesnullas its "no preference" value.What is the new behavior?
nullandundefinedfall back toInputType.TYPE_CLASS_TEXT, the same default unknown names already get. Explicit numeric input types, including0/TYPE_NULL, are still passed through unchanged.A new spec,
ui/editable-text-base/index.android.spec.ts, coversnull/undefined, unknown names, numeric passthrough, and named types. It fails without the fix.Closes #9194.