Skip to content

fix(core): resolve css inherit on non-inherited properties to the parent value #11521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
edusperoni wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(core): resolve css inherit on non-inherited properties to the parent value #11521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion apps/automated/src/ui/styling/css-keywords-tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export var test_value_Inherited_after_revert = function () {
TKUnit.assertEqual(btn.color.hex, '#FF0000', 'color property');
};

// TODO: Add missing inherit support for non-inherited properties
// A keyword set from code only releases the local value; see test_css_inherit_* for the stylesheet keyword.
export var test_value_after_inherit = function () {
let page = helper.getCurrentPage();
let btn = new Button();
Expand Down Expand Up @@ -130,3 +130,36 @@ export var test_value_Inherited_after_inherit = function () {
(btn as any).color = 'inherit';
TKUnit.assertEqual(btn.color.hex, '#FF0000', 'color property');
};

export var test_css_inherit_on_non_inherited_property = function () {
let page = helper.getCurrentPage();
let btn = new Button();
let testStack = new StackLayout();

page.css = 'StackLayout { background-color: #FF0000; margin-top: 7; } Button { background-color: inherit; margin-top: inherit; }';

page.content = testStack;
testStack.addChild(btn);

TKUnit.assertEqual(btn.backgroundColor.hex, '#FF0000', 'backgroundColor property');
TKUnit.assertEqual(btn.marginTop, 7, 'marginTop property');

testStack.backgroundColor = new Color('#0000FF');
testStack.marginTop = 3;
TKUnit.assertEqual(btn.backgroundColor.hex, '#0000FF', 'backgroundColor property follows the parent');
TKUnit.assertEqual(btn.marginTop, 3, 'marginTop property follows the parent');
};

export var test_css_inherit_on_shorthand = function () {
let page = helper.getCurrentPage();
let btn = new Button();
let testStack = new StackLayout();

page.css = 'StackLayout { border-color: #FF0000; } Button { border-color: inherit; }';

page.content = testStack;
testStack.addChild(btn);

TKUnit.assertEqual((<Color>btn.borderTopColor).hex, '#FF0000', 'borderTopColor property');
TKUnit.assertEqual((<Color>btn.borderLeftColor).hex, '#FF0000', 'borderLeftColor property');
};
Loading
Loading