Repository navigation
fix(ios): deliver launch urls, activities and quick actions to scene apps - #11518
Merged
Merged
Conversation
…apps With a scene manifest, UIKit hands the payloads that launch the app only to scene:willConnectToSession:options: (connectionOptions.URLContexts, userActivities and shortcutItem). scene:openURLContexts:, scene:continueUserActivity: and windowScene:performActionForShortcutItem: fire only once the scene is connected, so opening a file or link while the app was not running, or launching it from a quick action, was dropped: no scene event, and no call into handlers registered with addDelegateHandler. The connecting scene now delivers those payloads through the same path as the warm callbacks, after its content is resolved. The activity openWindow() uses to carry window data is not forwarded as a continuation.
|
View your CI Pipeline Execution ↗ for commit 9541233
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
NathanWalker
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Once an app declares
UIApplicationSceneManifest, UIKit stops callingapplication:openURL:options:,application:continueUserActivity:restorationHandler:andapplication:performActionForShortcutItem:completionHandler:. The scene delegate bridge covers the warm case by forwardingscene:openURLContexts:,scene:continueUserActivity:andwindowScene:performActionForShortcutItem:completionHandler:to those handlers.When one of these payloads is what launches the app, UIKit delivers it only in
scene:willConnectToSession:options:, asconnectionOptions.URLContexts,connectionOptions.userActivitiesorconnectionOptions.shortcutItem, and never calls the warm scene callbacks for it.sceneWillConnectToSessionOptionsdoesn't look at any of them (apart from readingopenWindow()data off the first activity), so:There is no
sceneOpenURLContexts/sceneContinueUserActivity/scenePerformActionForShortcutItemevent, and no call into handlers registered withApplication.ios.addDelegateHandler(). The same payloads work when the app is already running, which makes this easy to miss in development.What is the new behavior?
sceneWillConnectToSessionOptionsdelivers the launch payloads through the same path as the warm callbacks: it emits the scene event on the window and onApplication.ios, then forwards to the legacy delegate handler.openURLand friends arrived after launch had finished and the root view existed.openWindow()attaches to carry window data (<bundleId>.scene) is not forwarded as a continuation (newgetLaunchUserActivitieshelper inscene-delegate-bridge.ts).oneShotCompletionnow acceptsundefined.UIKit sends a given payload either at connect or through the warm callback, never both, so this doesn't double-deliver.
Tests cover the activity filtering and the completion-less
oneShotCompletion. The scene delegate itself isn't unit-testable without UIKit, so the cold-launch path was checked by reading the code against the warm callbacks and has not yet been run on a device.