Skip to content

Correct TabView icon rendering mode#1149

Merged
hshristov merged 2 commits intoNativeScript:masterfrom
rclai:patch-1
Nov 30, 2015
Merged

Correct TabView icon rendering mode#1149
hshristov merged 2 commits intoNativeScript:masterfrom
rclai:patch-1

Conversation

@rclai
Copy link
Copy Markdown
Contributor

@rclai rclai commented Nov 24, 2015

Fixes #1148.

@ns-bot
Copy link
Copy Markdown

ns-bot commented Nov 24, 2015

Can one of the admins verify this patch?

@ns-bot ns-bot added cla: yes and removed cla: no labels Nov 24, 2015
@rclai
Copy link
Copy Markdown
Contributor Author

rclai commented Nov 25, 2015

@enchev, is there something I need to do about the failed test of @ns-bot? I can't see the details.

@enchev
Copy link
Copy Markdown
Contributor

enchev commented Nov 25, 2015

Hey @rclai,

We have a problem with random failing tests for Android. No need to do anything extra.

@ns-bot
Copy link
Copy Markdown

ns-bot commented Nov 25, 2015

Test PASSed.

@ErjanGavalji
Copy link
Copy Markdown
Contributor

👍

1 similar comment
@hshristov
Copy link
Copy Markdown
Contributor

👍

@hshristov hshristov added this to the 1.5.1 milestone Nov 30, 2015
@vakrilov
Copy link
Copy Markdown
Contributor

👍

@hshristov hshristov added ready for test TSC needs to test this and confirm against live production apps and automated test suites bug severity: low os: ios labels Nov 30, 2015
hshristov pushed a commit that referenced this pull request Nov 30, 2015
Correct TabView icon rendering mode
@hshristov hshristov merged commit 72577a8 into NativeScript:master Nov 30, 2015
@lock
Copy link
Copy Markdown

lock bot commented Aug 29, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug cla: yes os: ios ready for test TSC needs to test this and confirm against live production apps and automated test suites severity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS TabView Icon rendering mode set wrong

6 participants