Skip to content

fix(vite): fold an exports-map plugin's root entry onto its bare package id #11411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Sep 3, 2026
Merged

fix(vite): fold an exports-map plugin's root entry onto its bare package id #11411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions packages/vite/hmr/server/websocket-module-specifiers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'fs';
import { tmpdir } from 'os';
import { join } from 'path';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';

import { resolveInternalRuntimePluginBareSpecifier } from './websocket-module-specifiers.js';

const CORE_PEER = { peerDependencies: { '@nativescript/core': '>=9.0.0' } };

function writePackage(root: string, name: string, pkg: Record<string, unknown>): void {
const dir = join(root, 'node_modules', ...name.split('/'));
mkdirSync(dir, { recursive: true });
writeFileSync(join(dir, 'package.json'), JSON.stringify({ name, version: '1.0.0', ...pkg }));
}

// Package names are unique per case: the exports reverse map is cached by name alone.
describe('resolveInternalRuntimePluginBareSpecifier', () => {
let root: string;

beforeEach(() => {
root = mkdtempSync(join(tmpdir(), 'ns-vite-plugin-specifier-'));
});

afterEach(() => {
rmSync(root, { recursive: true, force: true });
});

it('folds the root export of an exports-map plugin onto its bare package id', () => {
writePackage(root, '@nativescript-community/exports-root-fixture', {
...CORE_PEER,
exports: {
'./package.json': './package.json',
'.': { types: './dist/index.d.ts', import: './dist/index.js', default: './dist/index.js' },
'./config': './dist/config.js',
},
});
expect(resolveInternalRuntimePluginBareSpecifier('/node_modules/@nativescript-community/exports-root-fixture/dist/index.js', root)).toBe('@nativescript-community/exports-root-fixture');
});

it('leaves a subpath export to the vendor resolver', () => {
writePackage(root, '@nativescript-community/exports-subpath-fixture', {
...CORE_PEER,
exports: { '.': './dist/index.js', './config': './dist/config.js' },
});
expect(resolveInternalRuntimePluginBareSpecifier('/node_modules/@nativescript-community/exports-subpath-fixture/dist/config.js', root)).toBeNull();
});

it('keeps a package-internal file of an exports-map plugin as the concrete specifier', () => {
writePackage(root, '@nativescript-community/exports-internal-fixture', {
...CORE_PEER,
exports: { '.': './dist/index.js' },
});
expect(resolveInternalRuntimePluginBareSpecifier('/node_modules/@nativescript-community/exports-internal-fixture/dist/driver.js', root)).toBe('@nativescript-community/exports-internal-fixture/dist/driver.js');
});

it('folds a main-field plugin entry resolved to a platform file onto its bare package id', () => {
writePackage(root, '@nativescript-community/main-field-fixture', { ...CORE_PEER, main: 'dist/index' });
expect(resolveInternalRuntimePluginBareSpecifier('/node_modules/@nativescript-community/main-field-fixture/dist/index.ios.js', root)).toBe('@nativescript-community/main-field-fixture');
});
});
8 changes: 7 additions & 1 deletion packages/vite/hmr/server/websocket-module-specifiers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,13 @@ export function resolveInternalRuntimePluginBareSpecifier(spec: string, projectR

const reverseMap = getExportsReverseMap(packageName, projectRoot);
const originalSpec = reverseMap.get(subpath);
if (originalSpec && originalSpec !== packageName) {
// The device vendor registry serves plugins by bare package id, so the file
// the root export resolves to must fold back onto that id whether the
// package declares it through `exports` or `main`.
if (originalSpec === packageName) {
return packageName;
}
if (originalSpec) {
return null;
}

Expand Down
Loading