Skip to content

fix(core): iOS child index mapping skips the glass effect subview #11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): iOS child index mapping skips the glass effect subview #11410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/core/ui/core/view/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,6 +1003,19 @@ export class View extends ViewCommon {
IOSHelper.invalidateStatusBarAppearance(ownerController, `View.updateStatusBarStyle:${value}`);
}

public _childIndexToNativeChildIndex(index?: number): number {
if (typeof index !== 'number') {
return index;
}
// The glass effect view is a subview but not a child: it sits at subview
// 0, so every child's subview index is one past its child index.
const effectView = this._glassEffectView;
if (effectView && effectView.superview === this.nativeViewProtected) {
return index + 1;
}
return index;
}

[iosGlassEffectProperty.setNative](value: GlassEffectType) {
if (!this.nativeViewProtected || !supportsGlass()) {
return;
Expand Down
3 changes: 2 additions & 1 deletion packages/core/ui/layouts/layout-base-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ export class LayoutBaseCommon extends CustomLayoutView implements LayoutBaseDefi
result += this._subViews[i]._getNativeViewsCount();
}

return result;
// The platform base accounts for native subviews that are not children.
return super._childIndexToNativeChildIndex(result);
}

public eachChildView(callback: (child: View) => boolean): void {
Expand Down
Loading