fix(core): iOS scrollToVerticalOffset lands past the offset when there is a content inset - #11409
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
…e is a content inset Both scrollTo*Offset methods asked UIKit to scroll a viewport-sized rect into view. With a bottom (or right) content inset that rect cannot fit in the visible area, so UIKit aligned its far edge instead and the scroll ended contentInset.bottom past the requested offset — a chat scrolling to its last message with a docked composer inset overshot by the inset every time. The offset is now set directly, clamped to the range a user scroll can reach, which also matches what Android does.
|
View your CI Pipeline Execution ↗ for commit 00a192f
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScrollView.scrollToVerticalOffsetandscrollToHorizontalOffseton iOS asked UIKit to scroll a viewport-sized rect into view (scrollRectToVisiblewithCGRect(0, value, bounds.width, bounds.height)). With a bottom (or right) content inset, that rect cannot fit in the visible area, so UIKit aligns its far edge instead and the scroll endscontentInset.bottompast the requested offset. Any scroll view that keeps a content inset for a docked bar, a keyboard, oriosContentInsetAdjustmentBehaviorgets this.Fix
Set
contentOffsetdirectly, clamped to the range a user scroll can reach (-adjustedContentInset.topup tocontentSize + adjustedContentInset.bottom - bounds), for both orientations. This also matches Android, which already sets the scroll position directly.