fix(core): iOS box-shadow alpha was applied twice - #11407
Open
NathanWalker wants to merge 1 commit into
Open
NathanWalker wants to merge 1 commit into
NathanWalker wants to merge 1 commit into
Conversation
The shadow layer's opacity is set from the color's alpha, and the same color, alpha included, was also handed to shadowColor — so a CSS rgba(0, 0, 0, 0.3) shadow rendered at 0.09 and the usual subtle values were all but invisible. The color is now passed opaque and the alpha lives in shadowOpacity alone.
|
View your CI Pipeline Execution ↗ for commit 8b4d0f0
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
commit: |
CatchABus
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
drawBoxShadowinui/styling/background.ios.tssetsshadowLayer.shadowOpacityfrom the CSS color's alpha and then also assignsshadowLayer.shadowColorfrom the sameColor, whoseCGColorstill carries that alpha. Core Animation multiplies the two, so the effective opacity is the alpha squared:rgba(0, 0, 0, 0.3)renders at 0.09, and the subtle values designs actually use (0.08 to 0.15) are effectively invisible.Fix
Pass the color opaque (
colorWithAlphaComponent(1)) so the alpha lives inshadowOpacityalone.shadowOpacitystill reflects the CSS alpha, so nothing that reads it changes.