Skip to content

fix(ios): update swipe back gesture from Page property#11312

Merged
NathanWalker merged 1 commit into
NativeScript:mainfrom
tannerlinsley:taren/fix-dynamic-swipe-back
Jul 21, 2026
Merged

fix(ios): update swipe back gesture from Page property#11312
NathanWalker merged 1 commit into
NativeScript:mainfrom
tannerlinsley:taren/fix-dynamic-swipe-back

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What changed

  • bind enableSwipeBackNavigationProperty to the native gesture update hook
  • stop actionBarHidden changes from overwriting swipe-back state
  • add an iOS regression test that toggles the Page property and checks the native recognizer

The handler was lost during the property-system migration: enableSwipeBackNavigation remained public and was read during page presentation, but changing it on a visible page did not update either iOS gesture recognizer.

Validation

  • nx run core:build
  • nx run core:lint (passes with existing warnings)
  • iOS 26.5 simulator XCUITest: disabling the property prevents an interactive edge pop; re-enabling it restores the native transition

@NathanWalker NathanWalker self-assigned this Jul 21, 2026
@NathanWalker NathanWalker added this to the 9.1 milestone Jul 21, 2026
NathanWalker
NathanWalker approved these changes Jul 21, 2026
View reviewed changes

@NathanWalker NathanWalker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💯

@nx-cloud

nx-cloud Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c23541e

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 1s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 3s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-07-21 23:00:51 UTC

@tannerlinsley tannerlinsley mentioned this pull request Jul 21, 2026
Open
@tannerlinsley
tannerlinsley force-pushed the taren/fix-dynamic-swipe-back branch from 81ee9d5 to c23541e Compare July 21, 2026 22:43
@tannerlinsley

tannerlinsley commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

The first iOS run reached the Page suite, then the NativeScript runtime asserted in the unrelated test_WhenModalPageShownShowModalEventsRaisedOnRootModalTabView test and the job timed out. Android passed. I refreshed the single commit SHA to request a clean rerun, but the new iOS/Android workflows are now action_required and need maintainer approval. No implementation content changed in the refresh.

@NathanWalker
NathanWalker merged commit 36be5f4 into NativeScript:main Jul 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes
@CatchABus CatchABus CatchABus approved these changes

Assignees

@NathanWalker NathanWalker

Labels

None yet

Projects

None yet

Milestone

9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@tannerlinsley @NathanWalker @CatchABus