Skip to content

perf(core): Cache media query arrays in the ruleset#11309

Merged
NathanWalker merged 1 commit into
NativeScript:mainfrom
CatchABus:perf/media-queries-traversal
Jul 18, 2026
Merged

perf(core): Cache media query arrays in the ruleset#11309
NathanWalker merged 1 commit into
NativeScript:mainfrom
CatchABus:perf/media-queries-traversal

Conversation

@CatchABus

@CatchABus CatchABus commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

What is the new behavior?

This PR is a small piece for #11307 to improve media queries validation.
From now on:

  • A common media query will be stored as a string
  • A query with nested queries will be stored as an array

This also helps avoid storing unneeded arrays for single media queries while also avoiding using split and creating a new array during each validation.

@CatchABus
CatchABus requested a review from NathanWalker July 18, 2026 12:38
@CatchABus CatchABus changed the title perf(core): Cache nested media queries in the ruleset perf(core): Cache media query arrays in the ruleset Jul 18, 2026
@nx-cloud

nx-cloud Bot commented Jul 18, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 596f885

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 11s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 2s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-07-18 12:43:51 UTC

@NathanWalker
NathanWalker merged commit 51e762f into NativeScript:main Jul 18, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants