Repository navigation
feat: windows - #11272
Draft
triniwiz wants to merge 60 commits into
Draft
feat: windows#11272triniwiz wants to merge 60 commits into
triniwiz wants to merge 60 commits into
Conversation
|
View your CI Pipeline Execution ↗ for commit 4fe2d65
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
Collaborator
|
@triniwiz we should never write PRs like this. This is impossible to review and the possible regressions are numerous. |
NathanWalker
marked this pull request as draft
July 4, 2026 17:52
|
How to run C#(.net) from js/ts ? |
|
@triniwiz can you add an example for c# plugin? it's posible? |
A value that throws when applied (e.g. var() resolving to an invalid color) left the previously applied value in place. Per CSS Values 5, a declaration invalid at computed-value time computes as unset. https://drafts.csswg.org/css-values-5/#invalid-substitution
…n-proc server NSRegisterWidgetsActivatableClasses took the manifest's first inProcessServer, so when a plugin's registration ran first (e.g. canvas-media's canvasmedia.node) the Widgets classes were listed under that plugin's DLL and every widget activation failed with "Package ... not found". Select the server whose Path is NativeScript.Widgets.dll, as the plugin registrations do.
Conflict in deps-bundle discovery: main's lazy transitive evaluation reads each input's format from esbuild's metafile, but a failing build with metafile set crashes the process on esbuild 0.27, and the windows retry loop expects failures. The retry loop now probes without metafile, then one final metafile build runs on the known-resolvable entries.
resolveFsAnchoredSpec built /@fsc:/... on windows; add the separator like the served-module transformer does. Normalize separators in the new specs.
…gationButton sets text or an icon
WinUI leaves the system title bar light, so a dark app (or one switched with Application.systemAppearanceChanged) kept a light caption. The window's AppWindow title bar is now set when the window opens and on each appearance change: with PreferredTheme on Windows App SDK 1.7+, otherwise with the system's light or dark caption colors. Setting the colors needs a runtime that boxes struct values for IReference<T>.
WinUI only hit-tests a panel where it has a background, so a view with a tap or touch listener and no background got the pointer only over its children, and input went through it to whatever was underneath. A full-screen layer meant to catch taps outside a menu let them reach the page, and the wheel scrolled it. As on Android and iOS, a view with gestures now takes the pointer over its whole box: an unset background becomes transparent.
- Application.openWindow() and a NativeWindow per WinUI Window - @media measured per window - App exits once its last window closes (needs @nativescript/windows 1.0.0-beta.13)
…11468) * feat(windows): let a parent resolve its children's percentage sizes View gains _setChildPercentSize(child, horizontal, fraction), which returns false. A percentage width or height is handed to the parent's; when it returns true, core leaves the XAML Width/Height unset and skips its own percent sizing. Setting a length clears it (fraction null). * feat(windows): view location in window, on screen and relative to a view (#11515) getLocationInWindow and getLocationRelativeTo transform the element's origin through XAML; getLocationOnScreen adds the window's client origin, read off its AppWindow (cached per XamlRoot) by a window-helper util.
# Conflicts: # packages/vite/hmr/server/websocket-ns-m-request.ts # packages/vite/hmr/shared/vendor/manifest.spec.ts
The app ships in the package's app\ folder (ms-appx:///app/), but getCurrentAppPath() returned the InstalledLocation itself, so every ~/ path resolved through currentApp() (fonts, sounds, CSS imports, web-view and tab-view sources) pointed one folder too high and failed to open. currentApp() is now InstalledLocation\app, as on iOS (<bundle>/app) and Android (files/app). getLogicalRootPath() stays the package root, like the bundle root on iOS and files/ on Android.
Delete, rename, folder listing, size, last-modified and the sync read/write members called .done() (not part of the projection) or invoked methods on the pending IAsyncOperation instead of its result. Sync members now block on the operation, async members chain it, and failures surface the operation's HRESULT through onError/rejection. Also: writes create the file, append no longer overwrites, the appendBuffer members exist, folders never report an extension, and getFileExtension is implemented. Refs #11613
Values[key] reads and writes do not reach the IPropertySet on every engine; call HasKey/Lookup/Insert explicitly. remove() no longer throws for a missing key. Refs #11614
# Conflicts: # packages/core/ui/core/properties/css-variable-expression.spec.ts # packages/core/ui/core/properties/index.ts # packages/core/ui/styling/style-scope.spec.ts # packages/core/ui/styling/style-scope.ts
The modal Popup's Closed handler was attached with AddHandler(Popup.ClosedEvent, ...), but Popup.Closed is a plain event, not a routed one: Popup.ClosedEvent is undefined, the call threw and the empty catch hid it. Clicking outside a cancelable modal closed the Popup without running the modal's close logic, so the view kept its modal state and the close callback never fired. The handler is now assigned to popup.Closed and cleared with null on close. Also corrects the TextField comment: AddHandler(KeyDownEvent, handler, true) works with a runtime that boxes JS delegates for Object parameters (NativeScript/windows#41); the KeyDown event stays as the fallback for runtimes that can't.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new windows runtime.
Closes #254 (WinUI3)