Skip to content

fix(android): don't crash in Fragment.onCreateView on stale-fragment race #11264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(android): don't crash in Fragment.onCreateView on stale-fragment race #11264

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26d34e1
fix(android): don't crash in Fragment.onCreateView on stale-fragment …
NathanWalker Jun 9, 2026
2b51674
fix(android): always log onCreateView stale fragment guards as errors
Copilot Jun 17, 2026
11902bc
docs(android): clarify Trace.write error logging remains non-fatal
Copilot Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions packages/core/ui/frame/frame-helper-for-android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,21 +112,30 @@ export class FragmentCallbacksImplementation implements AndroidFragmentCallbacks

const entry = this.entry;
if (!entry) {
Trace.error(`${fragment}.onCreateView: entry is null or undefined`);
// Recoverable race: a stale fragment is being driven to onCreateView by the
// FragmentManager after its entry was cleared.
// Using Trace.error (routes to an error handler, which throws) would be fatal as the error handler rethrows across the JNI boundary.
// Trace.write(..., Trace.messageType.error) logs without routing through that throwing path.
Trace.write(`${fragment}.onCreateView: entry is null or undefined`, Trace.categories.NativeLifecycle, Trace.messageType.error);

return null;
}

const page = entry.resolvedPage;
if (!page) {
Trace.error(`${fragment}.onCreateView: entry has no resolvedPage`);
// Logging via Trace.error (routes to an error handler, which throws) here is fatal because the registered error handler rethrows across the JNI boundary.
// Trace.write(..., Trace.messageType.error) keeps this recoverable path non-fatal.
Trace.write(`${fragment}.onCreateView: entry has no resolvedPage`, Trace.categories.NativeLifecycle, Trace.messageType.error);

return null;
}

const frame = this.frame;
if (!frame) {
Trace.error(`${fragment}.onCreateView: this.frame is null or undefined`);
// Recoverable race: the owning frame was already torn down. Returning null discards
// this fragment; using Trace.error (routes to an error handler, which throws) would be fatal as the error handler rethrows across the JNI boundary.
// Trace.write(..., Trace.messageType.error) logs without invoking the throwing error handler.
Trace.write(`${fragment}.onCreateView: this.frame is null or undefined`, Trace.categories.NativeLifecycle, Trace.messageType.error);

return null;
}
Expand Down