Skip to content

fix(core): avoid firing removed event listeners #11263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Jun 8, 2026
+3 −2
Merged

fix(core): avoid firing removed event listeners #11263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/core/data/observable/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ interface ListenerEntry {
callback: (data: EventData) => void;
thisArg?: any;
once?: true;
_isRemoved?: true;
}

interface ListEntryMap {
Expand Down Expand Up @@ -301,7 +302,7 @@ export class Observable {

// If we have neither `thisArg` nor `callback`, just remove all events
// of this type regardless.

entry._isRemoved = true;
entries.splice(i, 1);
i--;
}
Expand Down Expand Up @@ -443,7 +444,7 @@ export class Observable {
}

private static _handleListenerEntry<T extends EventData>(entry: ListenerEntry, index: number, observers: Array<ListenerEntry>, data: T): void {
if (!entry) {
if (!entry || entry._isRemoved) {
return;
}

Expand Down
Loading