Skip to content

fix(ios): secureWithoutAutofill on TextField #11129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Mar 4, 2026
Merged

fix(ios): secureWithoutAutofill on TextField #11129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/toolbox/src/pages/forms.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,27 @@
</Page.actionBar>
<ScrollView>
<StackLayout padding="20">
<Label text="TextField:" fontWeight="bold" />
<Label text="TextField secureWithoutAutofill" fontWeight="bold" />
<TextField marginTop="6" backgroundColor="#efefef" padding="8" fontSize="18" secure="true" secureWithoutAutofill="true">
</TextField>

<Label text="TextField" fontWeight="bold" marginTop="12" />
<TextField textChange="{{ textChange }}" marginTop="6" backgroundColor="#efefef" padding="8" fontSize="18" keyboardType="url" />

<Label text="{{ textInput }}" marginTop="6" />

<Label text="SSN Formatted input:" fontWeight="bold" marginTop="12" />
<Label text="SSN Formatted input" fontWeight="bold" marginTop="12" />
<TextField hint="XXX-XX-XXXX" style.placeholderColor="silver" textChange="{{textChangeSSN}}" keyboardType="number" color="black" width="80%" borderColor="silver" borderWidth="1" height="40" textAlignment="center" borderRadius="4" valueFormatter="{{valueFormatterSSN}}" padding="5" maxLength="11">
</TextField>
<Label text="{{ formattedSSNInput }}" marginTop="6" />

<Label text="Phone Formatted input:" fontWeight="bold" marginTop="12" />
<Label text="Phone Formatted input" fontWeight="bold" marginTop="12" />
<TextField hint="XXX-XXX-XXXX" style.placeholderColor="silver" textChange="{{textChangePhone}}" keyboardType="number" color="black" width="80%" borderColor="silver" borderWidth="1" height="40" textAlignment="center" borderRadius="4" valueFormatter="{{valueFormatterPhone}}" padding="5" maxLength="12">
</TextField>
<Label text="{{ formattedPhoneInput }}" marginTop="6" />

<Label text="TextView" fontWeight="bold" marginTop="12" />
<TextView hint="Type text..." style.placeholderColor="silver" textChange="{{textChangeArea}}" color="black" width="80%" borderColor="silver" borderWidth="1" height="200" borderRadius="4" fontSize="14">
<TextView hint="Type text..." style.placeholderColor="silver" textChange="{{textChangeArea}}" color="black" width="80%" borderColor="silver" borderWidth="1" height="125" borderRadius="4" fontSize="14">
</TextView>

<Label text="TextField white-space + text-overflow" fontWeight="bold" marginTop="12" />
Expand Down
50 changes: 41 additions & 9 deletions packages/core/ui/text-field/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ class UITextFieldDelegateImpl extends NSObject implements UITextFieldDelegate {
public static ObjCProtocols = [UITextFieldDelegate];

private _owner: WeakRef<TextField>;
private firstEdit: boolean;

public static initWithOwner(owner: WeakRef<TextField>): UITextFieldDelegateImpl {
const delegate = <UITextFieldDelegateImpl>UITextFieldDelegateImpl.new();
Expand Down Expand Up @@ -125,6 +124,7 @@ export class TextField extends TextFieldBase {
super.initNativeView();
this._delegate = UITextFieldDelegateImpl.initWithOwner(new WeakRef(this));
this.nativeViewProtected.delegate = this._delegate;
this._applySecureWithoutAutofillTraits(this.nativeViewProtected);
}

disposeNativeView() {
Expand All @@ -140,6 +140,7 @@ export class TextField extends TextFieldBase {

public textFieldShouldBeginEditing(textField: UITextField): boolean {
this._firstEdit = true;
this._applySecureWithoutAutofillTraits(textField);

return this.editable;
}
Expand Down Expand Up @@ -174,14 +175,7 @@ export class TextField extends TextFieldBase {
}

public textFieldShouldChangeCharactersInRangeReplacementString(textField: UITextField, range: NSRange, replacementString: string): boolean {
if (this.secureWithoutAutofill && !textField.secureTextEntry) {
/**
* Helps avoid iOS 12+ autofill strong password suggestion prompt
* Discussed in several circles but for example:
* https://github.com/expo/expo/issues/2571#issuecomment-473347380
*/
textField.secureTextEntry = true;
}
this._applySecureWithoutAutofillTraits(textField);
Copy link
Copy Markdown
Contributor

@CatchABus CatchABus Mar 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need an extra flag to determine if the native props have already been updated and reduce _applySecureWithoutAutofillTraits calls since there are cases like reloadInputViews() that might be called multiple times while typing.
For instance, the old fix made sure to check whether secureTextEntry was already enabled or not before proceeding.

const delta = replacementString.length - range.length;
if (delta > 0) {
if (textField.text.length + delta > this.maxLength) {
Expand Down Expand Up @@ -243,6 +237,44 @@ export class TextField extends TextFieldBase {
}
[secureProperty.setNative](value: boolean) {
this.nativeTextViewProtected.secureTextEntry = value;
this._applySecureWithoutAutofillTraits(this.nativeTextViewProtected);
}

private _applySecureWithoutAutofillTraits(textField: UITextField): void {
if (!textField || !this.secureWithoutAutofill) {
return;
}

const nativeField = textField as any;
Copy link
Copy Markdown
Contributor

@CatchABus CatchABus Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is cast to any necessary here? I understand these props are available in UITextField.

Copy link
Copy Markdown
Contributor Author

@NathanWalker NathanWalker Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some properties are sdk level scoped so we can probably rather use SDK_VERSION scope on some.


textField.secureTextEntry = true;

if (nativeField.textContentType !== undefined) {
nativeField.textContentType = typeof UITextContentTypeOneTimeCode !== 'undefined' ? UITextContentTypeOneTimeCode : '';
}

if (nativeField.autocorrectionType !== undefined) {
nativeField.autocorrectionType = UITextAutocorrectionType.No;
}
if (nativeField.spellCheckingType !== undefined) {
nativeField.spellCheckingType = UITextSpellCheckingType.No;
}
if (nativeField.smartDashesType !== undefined) {
nativeField.smartDashesType = UITextSmartDashesType.No;
}
if (nativeField.smartQuotesType !== undefined) {
nativeField.smartQuotesType = UITextSmartQuotesType.No;
}
if (nativeField.smartInsertDeleteType !== undefined) {
nativeField.smartInsertDeleteType = UITextSmartInsertDeleteType.No;
}
if (nativeField.passwordRules !== undefined) {
nativeField.passwordRules = null;
}

if (nativeField.reloadInputViews) {
nativeField.reloadInputViews();
}
}

[colorProperty.getDefault](): { textColor: UIColor; tintColor: UIColor } {
Expand Down
Loading