Skip to content

feat: bind overridden value converters to the target#11018

Merged
NathanWalker merged 2 commits intomainfrom
feat/target-converters
Jan 31, 2026
Merged

feat: bind overridden value converters to the target#11018
NathanWalker merged 2 commits intomainfrom
feat/target-converters

Conversation

@triniwiz
Copy link
Member

@triniwiz triniwiz commented Dec 30, 2025

When a overridden property valueConverter is called it will now be bound to the target which can be useful for custom views detecting how to handle the incoming value

fontSizeProperty.overrideHandlers({
  name: 'fontSize',
  cssName: 'font-size',
  valueConverter: function (value) {
    if (this && this[isACustomView_]) {
      return value as never;
    }
    // fallback to core conversion
    return parseFloat(value as never);
  },

@nx-cloud
Copy link

nx-cloud bot commented Dec 30, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 59e3dee

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 3m 5s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-01 18:27:49 UTC

CatchABus
CatchABus reviewed Jan 20, 2026
View reviewed changes
@NathanWalker NathanWalker merged commit 906aba1 into main Jan 31, 2026
7 checks passed
@NathanWalker NathanWalker deleted the feat/target-converters branch January 31, 2026 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatchABus CatchABus CatchABus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@triniwiz @CatchABus @NathanWalker