Skip to content

feat(vite): improved workspace and windows compatibility #10959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NathanWalker wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat(vite): improved workspace and windows compatibility #10959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
26b74ac
feat(vite): improve workspace resolutions
NathanWalker Nov 23, 2025
2abf7bc
fix(vite): windows path handling
NathanWalker Nov 24, 2025
03f7d26
fix: cross platform file paths
NathanWalker Nov 25, 2025
40788e3
chore: dep cleanup
NathanWalker Dec 4, 2025
92fcb87
fix(vite): global flags for hmr
NathanWalker Dec 13, 2025
414ce43
chore: log cleanup
NathanWalker Dec 13, 2025
49a16c5
feat(vite): onHmrUpdate for custom app hmr update handling
NathanWalker Dec 13, 2025
60b2f3d
feat: improve hmr vite server ip connection cases
NathanWalker Dec 13, 2025
9df273f
feat: improvements for import.meta.hot
NathanWalker Dec 17, 2025
e8e1778
Merge remote-tracking branch 'origin/main' into feat/vite-improvements
NathanWalker Dec 21, 2025
8c57189
chore: oidc workflow improvements
NathanWalker Dec 21, 2025
d472881
fix(vite): ensure angular tsconfig prefers .app.json and falls back t…
NathanWalker Dec 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 28 additions & 8 deletions .github/workflows/secure_nx_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ jobs:
npx nx release publish --tag "${{ steps.ctx.outputs.dist_tag }}" --access public --verbose --dry-run

# Tag-triggered publishing: publish the single package referenced by the tag.
- name: nx release publish (tag)
- name: Build and Publish (tag)
if: ${{ steps.ctx.outputs.mode == 'tag' && vars.USE_NPM_TOKEN != 'true' }}
shell: bash
env:
Expand All @@ -296,19 +296,39 @@ jobs:
rm -f "$NPM_CONFIG_USERCONFIG" || true
fi

npx nx release publish \
--projects "${{ steps.taginfo.outputs.project }}" \
--tag "${{ steps.taginfo.outputs.dist_tag }}" \
--access public \
--verbose
project="${{ steps.taginfo.outputs.project }}"
dist_tag="${{ steps.taginfo.outputs.dist_tag }}"

echo "Building $project..."
npx nx build "$project" --skip-nx-cache

echo "Publishing from dist/packages/$project..."
cd "dist/packages/$project"

npm pack
tgz_file=$(ls *.tgz | head -n 1)
npm publish "$tgz_file" --tag "$dist_tag" --access public --verbose

- name: nx release publish (tag, token)
- name: Build and Publish (tag, token)
if: ${{ steps.ctx.outputs.mode == 'tag' && vars.USE_NPM_TOKEN == 'true' }}
shell: bash
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}
NPM_CONFIG_PROVENANCE: true
run: |
npx nx release publish --projects "${{ steps.taginfo.outputs.project }}" --tag "${{ steps.taginfo.outputs.dist_tag }}" --access public --verbose
set -euo pipefail
project="${{ steps.taginfo.outputs.project }}"
dist_tag="${{ steps.taginfo.outputs.dist_tag }}"

echo "Building $project..."
npx nx build "$project" --skip-nx-cache

echo "Publishing from dist/packages/$project..."
cd "dist/packages/$project"

npm pack
tgz_file=$(ls *.tgz | head -n 1)
npm publish "$tgz_file" --tag "$dist_tag" --access public --verbose

- name: Summary
if: always()
Expand Down
2 changes: 1 addition & 1 deletion apps/automated/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@nativescript/vite": "file:../../dist/packages/vite",
"@nativescript/webpack": "file:../../dist/packages/webpack5",
"circular-dependency-plugin": "^5.2.2",
"typescript": "~5.8.0"
"typescript": "~5.9.3"
},
"gitHead": "c06800e52ee1a184ea2dffd12a6702aaa43be4e3",
"readme": "NativeScript Application"
Expand Down
5 changes: 3 additions & 2 deletions apps/toolbox/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,15 @@
"dependencies": {
"@nativescript/core": "file:../../packages/core",
"@nativescript/imagepicker": "^4.1.0",
"nativescript-theme-core": "file:../../node_modules/nativescript-theme-core"
"nativescript-theme-core": "file:../../node_modules/nativescript-theme-core",
"@valor/nativescript-websockets": "file:../../node_modules/@valor/nativescript-websockets"
},
"devDependencies": {
"@nativescript/android": "~9.0.0",
"@nativescript/ios": "~9.0.0",
"@nativescript/visionos": "~9.0.0",
"@nativescript/vite": "file:../../dist/packages/vite",
"@nativescript/webpack": "file:../../dist/packages/webpack5",
"typescript": "~5.8.0"
"typescript": "~5.9.3"
}
}
2 changes: 1 addition & 1 deletion apps/toolbox/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"debug": {
"executor": "@nativescript/nx:debug",
"options": {
"noHmr": true,
"noHmr": false,
"uglify": false,
"release": false,
"forDevice": false,
Expand Down
4 changes: 2 additions & 2 deletions apps/ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@
},
"dependencies": {
"@nativescript/core": "file:../../packages/core",
"nativescript-theme-core": "file:../../node_modules/nativescript-theme-core"
"nativescript-theme-core": "^1.0.4"
},
"devDependencies": {
"@nativescript/android": "~9.0.0",
"@nativescript/ios": "~9.0.0",
"@nativescript/visionos": "~9.0.0",
"@nativescript/webpack": "file:../../dist/packages/webpack5",
"typescript": "~5.8.0"
"typescript": "~5.9.3"
},
"gitHead": "8ab7726d1ee9991706069c1359c552e67ee0d1a4",
"readme": "NativeScript Application",
Expand Down
Loading