feat(slider): add support for linear gradients for min/max track#10953
Closed
TONYSTARK-EDITH wants to merge 5 commits intoNativeScript:mainfrom
Closed
feat(slider): add support for linear gradients for min/max track#10953TONYSTARK-EDITH wants to merge 5 commits intoNativeScript:mainfrom
TONYSTARK-EDITH wants to merge 5 commits intoNativeScript:mainfrom
Conversation
Contributor
|
Thank you for this PR @TONYSTARK-EDITH and your efforts here. We ended up merging this related pr #11015 due to the surface area simplicity, but look forward to your proposals anytime ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(slider): add support for linear gradients for min/max track
Add support for applying LinearGradient instances to a Slider's min and max tracks
on Android and iOS.
minTrackGradientandmaxTrackGradientonSliderBase.drawable while preserving original layer IDs.
CAGradientLayerinto a resizable track image withproper scale, corner radius and angle handling.
retrieval and gradient updates.
Notes:
offsets are absent.
Breaking changes: none
Closes: #5940