Skip to content

feat(core): Ensure concurrency when firing events#10946

Merged
NathanWalker merged 1 commit into
NativeScript:mainfrom
CatchABus:feat/concurrent-event-listeners
Nov 12, 2025
Merged

feat(core): Ensure concurrency when firing events#10946
NathanWalker merged 1 commit into
NativeScript:mainfrom
CatchABus:feat/concurrent-event-listeners

Conversation

@CatchABus

@CatchABus CatchABus commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Right now, core has concurrency problems when it comes to firing events.
To mitigate this for regular events, listener callbacks are fired in the reverse order thanks to #854.
Also, in the case of gesture listeners, some callbacks aren't fired if removeEventListener is called inside one of them while firing the event.

What is the new behavior?

Keep a copy of listener array when there's more than 1 of them.
This will ensure concurrency while firing events and event callbacks will fire in the correct order.

BREAKING CHANGES:

If by any chance there are users who rely in the faulty execution order, this change will affect them.

@nx-cloud

nx-cloud Bot commented Nov 9, 2025

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d0c940b

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 2m 19s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-09 13:50:29 UTC

@CatchABus CatchABus marked this pull request as ready for review November 12, 2025 00:38
@NathanWalker NathanWalker merged commit 1e55f0c into NativeScript:main Nov 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants