Skip to content

fix(android): ListView margin handling on layout containers #10937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 2 commits into from
Nov 5, 2025
Merged

fix(android): ListView margin handling on layout containers #10937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2465292
fix(android): ListView now honors margin on layout containers
NathanWalker Nov 5, 2025
882f048
chore: cleanup
NathanWalker Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions packages/core/ui/list-view/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { ItemEventData, ItemsSource } from '.';
import { ListViewBase, separatorColorProperty, itemTemplatesProperty } from './list-view-common';
import { View, KeyedTemplate } from '../core/view';
import { PercentLength } from '../styling/length-shared';
import { unsetValue } from '../core/properties/property-shared';
import { CoreTypes } from '../../core-types';
import { Color } from '../../color';
Expand Down Expand Up @@ -404,11 +405,28 @@ function ensureListViewAdapterClass() {

this.owner._prepareItem(args.view, index);
if (!args.view.parent) {
// Proxy containers should not get treated as layouts.
// Wrap them in a real layout as well.
// Ensure margins defined on the template root are honored on Android ListView.
// ListView's children don't support layout margins, so we insert an outer wrapper
// and keep the original view (with its margins) inside. This mirrors iOS spacing.

// If the view is already a LayoutBase (typical for templates like GridLayout),
// we wrap it so its margins take effect. For non-layout roots (labels, etc.)
// we already wrap below with a StackLayout.
if (args.view instanceof LayoutBase && !(args.view instanceof ProxyViewContainer)) {
this.owner._addView(args.view);
convertView = args.view.nativeViewProtected;
const mt = PercentLength.toDevicePixels(args.view.marginTop, 0, Number.NaN);
const mb = PercentLength.toDevicePixels(args.view.marginBottom, 0, Number.NaN);
const ml = PercentLength.toDevicePixels(args.view.marginLeft, 0, Number.NaN);
const mr = PercentLength.toDevicePixels(args.view.marginRight, 0, Number.NaN);
const hasMargins = mt > 0 || mb > 0 || ml > 0 || mr > 0;
if (hasMargins) {
const outer = new StackLayout();
outer.addChild(args.view);
this.owner._addView(outer);
convertView = outer.nativeViewProtected;
} else {
this.owner._addView(args.view);
convertView = args.view.nativeViewProtected;
}
} else {
const sp = new StackLayout();
sp.addChild(args.view);
Expand Down