fix(android): ListView margin handling on layout containers #10937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 882f048
☁️ Nx Cloud last updated this comment at |
NathanWalker
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Android ListView to properly respect margin properties defined on list item template roots. Previously, margins were ignored because ListView children don't natively support layout margins on Android.
- Adds logic to detect margins on item template views and wrap them in an outer StackLayout when needed
- Updates comments to clarify the wrapping behavior for both layout and non-layout template roots
- Imports
PercentLengthutility to correctly convert margin values to device pixels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Margins are now honored for items in the Android
ListViewcomponent, ensuring consistent spacing with iOS.Context: Android ListView ignores margins on the item root by design; each row’s root view is attached with AbsListView.LayoutParams, which doesn't support margins. These changes allow for consistent expectations for user layouts across iOS and Android.
When using a ListView with a setup similar to the following:
Before:
After:
