Skip to content

fix(android): make button default text not all caps for improved consistency #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Sep 16, 2025
Merged

fix(android): make button default text not all caps for improved consistency #10854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"eslint": "~8.57.0",
"eslint-config-prettier": "^10.0.0",
"fork-ts-checker-webpack-plugin": "^7.0.0",
"form-data": ">=4.0.4",
"form-data": ">=4.0.4",
"gonzales": "^1.0.7",
"husky": "^9.0.0",
"jest": "30.0.5",
Expand Down Expand Up @@ -104,12 +104,12 @@
"zx": "^8.3.0",
"jest-util": "30.0.5"
},
"overrides": {
"form-data": ">=4.0.4"
},
"overrides": {
"form-data": ">=4.0.4"
},
"lint-staged": {
"**/*.{js,ts,css,scss,json,html}": [
"npx prettier --write"
]
}
}
}
2 changes: 2 additions & 0 deletions packages/core/ui/button/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@ export class Button extends ButtonBase {
public initNativeView(): void {
super.initNativeView();
const nativeView = this.nativeViewProtected;
// make consistent with iOS, easier on users given css styling
nativeView.setAllCaps(false);
initializeClickListener();
const clickListener = new ClickListener(this);
nativeView.setOnClickListener(clickListener);
Expand Down