-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(core): Added support for style direction property (ltr/rtl) #10691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c165b2e
feat(core): Added support for style direction property (ltr/rtl)
CatchABus 1b63592
fix: Android text-align left and right misbehaved in rtl apps
CatchABus aa64ab8
fix: Corrected text alignment when layout direction is rtl
CatchABus da46c92
feat: Added start/end types for horizontal alignment
CatchABus 4771081
fix(ios): Button default text alignment should be center for both pla…
CatchABus b551883
fix: Android labels should respect layout direction
CatchABus 91bc44f
fix: Corrected iOS flex-direction row-reverse
CatchABus c31e330
feat: Added hasRtlSupport helper function
CatchABus ba60e8c
fix: Use TextAlignment API only on Labels and when rtl support is ena…
CatchABus 25b61ab
test: Added new automated tests for label text alignment
CatchABus e5b8926
chore: Removed unneeded direction defaults
CatchABus c41e3ba
fix: Corrected iOS automated tests that failed
CatchABus cd4fa5a
ref: Convert method hasRtlSupport to static as it was confusing
CatchABus 20fee44
ref: Text alignment improvements
CatchABus b1200d3
chore: Removed unneeded tests function
CatchABus ecdffd5
feat: Added support for application-specific layout direction
CatchABus e16c6a6
chore: Compatibility corrections
CatchABus 5357e06
chore: Minor import correction
CatchABus 82763e6
chore: Added null-check for ios button
CatchABus 94965f2
chore: Added missing import
CatchABus c65b5bc
chore: Corrected a failing test
CatchABus 4854f88
feat: Added support for deciding text ellipsis based on direction
CatchABus f82dc3d
chore: Added a property that was accidentally removed
CatchABus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.