fix(android): Background image incorrect aspect ratio#10651
Merged
NathanWalker merged 4 commits intoNativeScript:mainfrom Jan 13, 2025
Merged
fix(android): Background image incorrect aspect ratio#10651NathanWalker merged 4 commits intoNativeScript:mainfrom
NathanWalker merged 4 commits intoNativeScript:mainfrom
Conversation
NathanWalker
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
On android, there are cases when large images used as backgrounds lose their aspect ratio.
That is due to hardcoded limits in
Fetcherclass that attempt to downscale bitmaps to device screen bounds at certain cases.What I mentioned above is an old feature that's implemented since old
tns-core-widgetsrepo.See NativeScript/tns-core-modules-widgets#115
Here is an example of how a large image used as a background with size
containlooks in both platforms.You'll notice that the android version upscales vertically.
What is the new behavior?
From now on, background fetched images will keep aspect ratio by default.
Result