Repository navigation
feat(core): Added css class for styling dialog nested elements - #10605
Merged
NathanWalker merged 2 commits intoAug 23, 2024
Merged
Conversation
NathanWalker
approved these changes
Aug 23, 2024
|
please also add how to use it in the documentation page |
Contributor
Author
That's a good idea. Thanks for pointing out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Ever since #10201, Dialog buttons, labels, and inputs are affected by global scope CSS. That brings the drawback of not being able to style the dialog specifically. One good example example, some apps ended up with light-colored text not being distinct in light-mode Dialogs because of how these apps were styled in global scope.
What is the new behavior?
Added
ns-dialog-itemcss class to style nested dialog views.Sample: