Skip to content

feat(core): Added css class for styling dialog nested elements - #10605

Merged
NathanWalker merged 2 commits into
NativeScript:mainfrom
CatchABus:feat-dialog-items-css-class
Aug 23, 2024
Merged

NathanWalker merged 2 commits into
NativeScript:mainfrom
CatchABus:feat-dialog-items-css-class

Conversation

@CatchABus

@CatchABus CatchABus commented Aug 10, 2024 •

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

Ever since #10201, Dialog buttons, labels, and inputs are affected by global scope CSS. That brings the drawback of not being able to style the dialog specifically. One good example example, some apps ended up with light-colored text not being distinct in light-mode Dialogs because of how these apps were styled in global scope.

What is the new behavior?

Added ns-dialog-item css class to style nested dialog views.

Sample:

Label {
  color: #fff;
}

Label.ns-dialog-item {
  color: #000;
}

@cla-bot cla-bot Bot added the cla: yes label Aug 10, 2024
@NathanWalker
NathanWalker merged commit 6104b5b into NativeScript:main Aug 23, 2024
@dyazincahya

dyazincahya commented Oct 24, 2024 •

Copy link
Copy Markdown

please also add how to use it in the documentation page

@CatchABus

Copy link
Copy Markdown
Contributor Author

please also add how to use it in the documentation page

That's a good idea. Thanks for pointing out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants