fix: Remove reference in NPS config to old Webpack package, and add reference to Webpack 5 unit tests. #10526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference to Webpack5 unit tests.
SeanKelly369
approved these changes
Apr 24, 2024
SeanKelly369
left a comment
SeanKelly369
left a comment
There was a problem hiding this comment.
Anyone still using webpack 4 or older at this stage shouldn't be.
rigor789
approved these changes
May 1, 2024
apburgess
added a commit
to apburgess/NativeScript
that referenced
this pull request
May 15, 2024
apburgess
added a commit
to apburgess/NativeScript
that referenced
this pull request
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Using 'npm start' (as in the documentation) shows a menu where you can pick from the various project build scripts and unit tests. This menu still contains reference to the old Webpack package, and launching either of the options associated with it gives an error. There is also no menu option to invoke the Webpack5 unit tests.
What is the new behavior?
Removes the references to the old Webpack package from the NPS config file, and adds a reference to invoke the unit testing for the Webpack5 package.
Fixes/Implements/Closes #[Issue Number].