Skip to content

fix(android): crash on writeText on Android > 29#10466

Merged
NathanWalker merged 1 commit intoNativeScript:mainfrom
Akylas:android_writetext_29
Jan 3, 2024
Merged

fix(android): crash on writeText on Android > 29#10466
NathanWalker merged 1 commit intoNativeScript:mainfrom
Akylas:android_writetext_29

Conversation

@farfromrefug
Copy link
Copy Markdown
Collaborator

it was failing if you were to pass content://com.android.externalstorage.documents/document/primary%3ADownload%2Fcom.akylas.documentscanner_settings_2024-01-02.json.
It was trying to write com.akylas.documentscanner_settings_2024-01-02.json/com.akylas.documentscanner_settings_2024-01-02.json instead of com.akylas.documentscanner_settings_2024-01-02.json. It seems the getFile method is wrong.

This is not the perfect fix but in the meaning it should always work

@farfromrefug farfromrefug requested a review from triniwiz January 2, 2024 21:42
Copy link
Copy Markdown
Member

@triniwiz triniwiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NathanWalker NathanWalker merged commit 02e2801 into NativeScript:main Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants