Skip to content

fix(css): box-shadow none handling - #10445

Merged
NathanWalker merged 1 commit into
mainfrom
fix/box-shadow-none
Nov 19, 2023
Merged

NathanWalker merged 1 commit into
mainfrom
fix/box-shadow-none

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Nov 19, 2023 •

Copy link
Copy Markdown
Contributor

PR Checklist

What is the current behavior?

box-shadow: none had slightly different behavior between platforms (ios would create CALayers unnecessarily and Android would throw error).

What is the new behavior?

This none condition is now handled the same across both and avoids any unnecessary work.

closes #10403

@cla-bot cla-bot Bot added the cla: yes label Nov 19, 2023

@CatchABus CatchABus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. No problems occured after testing.

@NathanWalker
NathanWalker merged commit 6744009 into main Nov 19, 2023
@NathanWalker
NathanWalker deleted the fix/box-shadow-none branch November 19, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when box-shadow is set no none

2 participants