Repository navigation
fix(core): Page frame reference not unset on native view disposal - #10417
Merged
Merged
Conversation
CatchABus
marked this pull request as draft
October 21, 2023 00:18
CatchABus
marked this pull request as ready for review
October 21, 2023 01:31
NathanWalker
approved these changes
Oct 21, 2023
tdermendjiev
pushed a commit
to tdermendjiev/NativeScript
that referenced
this pull request
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There is currently an issue on Svelte Native that's related to HMR removing page elements and throwing exception.
The reason is that even though
_removeViewunsets page parent, the page still keeps reference of parent using property_frameand parent Frame happens to check that property when trying to dispose entry views in Core.What is the new behavior?
This change will ensure page won't keep any reference to parent after disposal. Doing so helps avoid calling
_removeViewmultiple times.More specifically, it ends up meddling with the following check:
https://github.com/NativeScript/NativeScript/blob/main/packages/core/ui/frame/frame-common.ts#L201
Fixes #10361 halfnelson/svelte-native#347