Repository navigation
fix(ios): Add/remove shadow for reusable views - #10409
Merged
NathanWalker merged 2 commits intoOct 14, 2023
Merged
Conversation
NathanWalker
approved these changes
Oct 14, 2023
2 of 5 tasks
tdermendjiev
pushed a commit
to tdermendjiev/NativeScript
that referenced
this pull request
Oct 25, 2023
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When it comes to reusable views, it seems that view box shadow is not removed when view gets removed from view tree.
That is because shadow layer belongs to parent and we rely on
disposeNativeViewto cleanup shadows but that doesn't seem to be the right approach.What is the new behavior?
Add/remove shadows along with view, regardless of being reusable or not. It's also a good replacement for my previous PR.