Skip to content

fix(ios): Setting of property mask on 'undefined' during view disposal #10404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 1 commit into from
Oct 14, 2023
Merged

fix(ios): Setting of property mask on 'undefined' during view disposal #10404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/core/ui/core/view/index.ios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,14 @@ export class View extends ViewCommon implements ViewDefinition {
this._hasTransform = false;
this._hasPendingTransform = false;

// Make sure shadows get removed
this.style.backgroundInternal.clearFlags |= BackgroundClearFlags.CLEAR_BOX_SHADOW;
// If native view extends UIView, perform a background cleanup to get rid of shadow layers
if (this.nativeViewProtected instanceof UIView) {
// Make sure shadows get removed
this.style.backgroundInternal.clearFlags |= BackgroundClearFlags.CLEAR_BOX_SHADOW;

// Perform background cleanup
iosBackground.clearBackgroundVisualEffects(this);
// Perform background cleanup
iosBackground.clearBackgroundVisualEffects(this);
}
}

public requestLayout(): void {
Expand Down